Review Request 113193: fix some warnings
Alexander Richardson
arichardson.kde at googlemail.com
Sat Oct 12 19:47:33 UTC 2013
> On Oct. 12, 2013, 9:23 p.m., Sebastian Kügler wrote:
> > src/declarativeimports/core/dialog.cpp, line 63
> > <http://git.reviewboard.kde.org/r/113193/diff/2/?file=200504#file200504line63>
> >
> > We normally use just 0 for this.
I will change that before committing.
Otherwise good to go in?
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113193/#review41614
-----------------------------------------------------------
On Oct. 10, 2013, 10:40 p.m., Alexander Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113193/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2013, 10:40 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> fix some warnings
>
>
> Diffs
> -----
>
> src/shell/desktopview.cpp 8eda4be9bed60498a603c67a4234a8c669b729c0
> src/scriptengines/qml/plasmoid/containmentinterface.cpp d7438506c6d120429d24d6680821030398af6101
> src/declarativeimports/core/dialog.cpp 4f1d9c8d901b6ce5b14963229bf6b28fc57c8463
> src/declarativeimports/calendar/calendar.h 5d1f3942501e00235e43b0431a42c5b44f45bc5a
>
> Diff: http://git.reviewboard.kde.org/r/113193/diff/
>
>
> Testing
> -------
>
> warnings are gone
>
>
> Thanks,
>
> Alexander Richardson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131012/72f6b575/attachment.html>
More information about the Plasma-devel
mailing list