Review Request 113179: Make the runners compile again

Aleix Pol Gonzalez aleixpol at kde.org
Thu Oct 10 18:29:26 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113179/
-----------------------------------------------------------

(Updated Oct. 10, 2013, 6:29 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
-------

Recently there's been some big changes in the ThreadWeaver API. So big that they break the source compatibility we were supposed to maintain, big time.

This patch tries to port plasma-framework to that new API.


Diffs
-----

  src/plasma/CMakeLists.txt 411256a 
  src/plasma/private/runnerjobs.cpp d11f7e9 
  src/plasma/private/runnerjobs_p.h 7fd7076 
  src/plasma/private/storage.cpp 35b222e 
  src/plasma/runnermanager.cpp 135279e 
  src/plasma/scripting/runnerscript.cpp d5142a2 

Diff: http://git.reviewboard.kde.org/r/113179/diff/


Testing
-------

Everything builds, including kde-workspace.

Couldn't test it, there's no tests for it or even an application to test it :/.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131010/9ca47bba/attachment.html>


More information about the Plasma-devel mailing list