Review Request 113179: Make the runners compile again

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113179/#review41496
-----------------------------------------------------------

Ship it!


With the two issues I've pointed out, this patch can be committed, as it's not going to cause merge conflicts.

- Sebastian Kügler


On Oct. 8, 2013, 5:14 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113179/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2013, 5:14 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Recently there's been some big changes in the ThreadWeaver API. So big that they break the source compatibility we were supposed to maintain, big time.
> 
> This patch tries to port plasma-framework to that new API.
> 
> 
> Diffs
> -----
> 
>   src/plasma/CMakeLists.txt 411256a 
>   src/plasma/private/runnerjobs.cpp d11f7e9 
>   src/plasma/private/runnerjobs_p.h 7fd7076 
>   src/plasma/private/storage.cpp 35b222e 
>   src/plasma/runnermanager.cpp 135279e 
>   src/plasma/scripting/runnerscript.cpp d5142a2 
> 
> Diff: http://git.reviewboard.kde.org/r/113179/diff/
> 
> 
> Testing
> -------
> 
> Everything builds, including kde-workspace.
> 
> Couldn't test it, there's no tests for it or even an application to test it :/.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131010/4028b16c/attachment.html>