Review Request 113124: MouseEventListener: Don't process event from children multiple times

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113124/#review41288
-----------------------------------------------------------



plasma/declarativeimports/qtextracomponents/mouseeventlistener.cpp
<http://git.reviewboard.kde.org/r/113124/#comment30266>

    Not sure about the 'return true' - I think MouseEventListener is supposed to never accept events itself. Doesn't the dupe check itself suffice?


- Eike Hein


On Oct. 5, 2013, 9:01 p.m., Nicolás Alvarez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113124/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2013, 9:01 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 316546
>     http://bugs.kde.org/show_bug.cgi?id=316546
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> MouseEventListener: Don't process event from children multiple times.
> 
> If an event passed through multiple visually-overlapping children of
> MouseEventListener, the event filter was processing the event every time.
> For example, this caused problems for the KMix icon in the tray, which
> would trigger volume changes three times for every mouse wheel event.
> 
> BUG:316546
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/qtextracomponents/mouseeventlistener.cpp 36530e075dc52348f32032c32457a090b904c3b9 
> 
> Diff: http://git.reviewboard.kde.org/r/113124/diff/
> 
> 
> Testing
> -------
> 
> The KMix problem is gone, each mouse wheel step now changes the volume by the appropriate amount.
> 
> 
> Thanks,
> 
> Nicolás Alvarez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131005/f6548214/attachment.html>