Review Request 114223: Moving popupmenu to mediacenter and making it more generic

[Shantanu Tushar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114223/#review44898
-----------------------------------------------------------

Ship it!


Ship It!

- Shantanu Tushar


On Nov. 30, 2013, 5:07 p.m., Sujith Haridasan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114223/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2013, 5:07 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Moving popup menu to mediacenter.qml and hence making it more generic. popup menu is pushed to the pagestack and hence it helps the user in keyboard navigation using Esc key too.
> 
> 
> Diffs
> -----
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 860b794 
>   mediaelements/popupmenu/PopupMenu.qml 6a832f7 
>   mediaelements/mediabrowser/MediaBrowser.qml ec76b99 
> 
> Diff: http://git.reviewboard.kde.org/r/114223/diff/
> 
> 
> Testing
> -------
> 
> Tested by moving the popup menu to mediacenter by launching pmc. And also when pressed the Esc key it takes user to the files section of the media browser.
> 
> 
> Thanks,
> 
> Sujith Haridasan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131130/ad3c606b/attachment.html>