Review Request 114149: Fix plasma on multiple monitors

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114149/
-----------------------------------------------------------

(Updated Nov. 28, 2013, 12:16 p.m.)


Review request for Plasma.


Changes
-------

Updated as per Martin's comments. Connecting to the function with the Qt5 syntax is possible, but not easy. It's quite interesting though.
QWindow::setGeometry is an overloaded function; there's a version with 4 ints and a version with a QRect, which is why it didn't work when I first tried. 

The only solution is to cast it so the compiler knows which function you meant.


Repository: plasma-framework


Description
-------

Set geometry to fill each screen correctly

DesktopView incorrectly filled the geometry of screen()
screen() will be the screen of the parent shell, not the correct
screen.

As we were already part-using QScreen, shellcorona is ported to use that instead
of QDesktopWidget, so we can keep track of which screen is actually removed instead of just assuming it was the last one.


Diffs (updated)
-----

  src/shell/desktopview.h b8b9caa 
  src/shell/desktopview.cpp 90a5730 
  src/shell/shellcorona.h ee5e2bc 
  src/shell/shellcorona.cpp ef6fbe2 

Diff: http://git.reviewboard.kde.org/r/114149/diff/


Testing
-------

Used two monitors, and I now have a different wallpaper on each \o/

There's a crash on unplugging a monitor, this happens before my patch and appears to be unrelated.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131128/b6da46b3/attachment.html>