Review Request 114149: Fix plasma on multiple monitors

[David Edmundson]

> On Nov. 27, 2013, 1:02 p.m., Martin Gräßlin wrote:
> > src/shell/desktopview.cpp, lines 144-147
> > <http://git.reviewboard.kde.org/r/114149/diff/1/?file=220663#file220663line144>
> >
> >     why did you introduce this new slot? It looks to me like you could just connet to setGeometry directly?

It's not a slot in QWindow and I can't use a lambda because then I can't disconnect.


> On Nov. 27, 2013, 1:02 p.m., Martin Gräßlin wrote:
> > src/shell/shellcorona.cpp, line 200
> > <http://git.reviewboard.kde.org/r/114149/diff/1/?file=220665#file220665line200>
> >
> >     any specific reason why you use Q_FOREACH and not the new for-syntax?
> >     for (QScreen *screen : QGuiApplications::screen())
> >     
> >     I prefer the new for syntax as it's not a macro and also works with multiple templates and is not YELLING ;-)

ok, I shall change to the NEW TEMPLATE FOR YOU.


> On Nov. 27, 2013, 1:02 p.m., Martin Gräßlin wrote:
> > src/shell/shellcorona.cpp, lines 396-397
> > <http://git.reviewboard.kde.org/r/114149/diff/1/?file=220665#file220665line396>
> >
> >     suggestion:
> >     for (auto i = d->views.begin(); i != d->views.end(); i++) {
> >        // if-condition as is
> >     }

++


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114149/#review44567
-----------------------------------------------------------


On Nov. 27, 2013, 11:34 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114149/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2013, 11:34 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Set geometry to fill each screen correctly
> 
> DesktopView incorrectly filled the geometry of screen()
> screen() will be the screen of the parent shell, not the correct
> screen.
> 
> As we were already part-using QScreen, shellcorona is ported to use that instead
> of QDesktopWidget, so we can keep track of which screen is actually removed instead of just assuming it was the last one.
> 
> 
> Diffs
> -----
> 
>   src/shell/desktopview.h b8b9caa 
>   src/shell/desktopview.cpp 90a5730 
>   src/shell/shellcorona.h ee5e2bc 
>   src/shell/shellcorona.cpp ef6fbe2 
> 
> Diff: http://git.reviewboard.kde.org/r/114149/diff/
> 
> 
> Testing
> -------
> 
> Used two monitors, and I now have a different wallpaper on each \o/
> 
> There's a crash on unplugging a monitor, this happens before my patch and appears to be unrelated.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131127/d84f690e/attachment-0001.html>