Review Request 114114: Remove KLocale QML bindings usage from kde-workspace

Commit Hook null at kde.org
Tue Nov 26 23:41:05 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114114/#review44552
-----------------------------------------------------------


This review has been submitted with commit 47340c61a68f0c7155a6f5588b93d03dcd88c778 by Martin Klapetek to branch master.

- Commit Hook


On Nov. 25, 2013, 6:30 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114114/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 6:30 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> They are unused. Furthermore KLocale is part of kde4support and we don't want to depend on that.
> 
> After all usage is removed (where removed means either removed unused or ported to QLocale QML bindings) from plasma-frameworks, I'll drop the bindings themselves.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/kickoff/package/contents/ui/configGeneral.qml 6f2bf7b 
>   plasma/generic/applets/analog-clock/contents/ui/configGeneral.qml 968b26c 
>   plasma/generic/applets/batterymonitor/contents/ui/BatteryItem.qml 7057120 
>   plasma/generic/applets/batterymonitor/contents/ui/BrightnessItem.qml 841a050 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml ab05d68 
>   plasma/generic/applets/batterymonitor/contents/ui/PowerManagementItem.qml e613ec2 
>   plasma/generic/applets/notifications/contents/ui/main.qml b22d30b 
> 
> Diff: http://git.reviewboard.kde.org/r/114114/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131126/f42b64ba/attachment.html>


More information about the Plasma-devel mailing list