Review Request 114112: Port digital clock plasmoid away from KLocale to QLocale
Sebastian Kügler
sebas at kde.org
Mon Nov 25 16:24:56 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114112/#review44441
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Kügler
On Nov. 25, 2013, 3:47 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114112/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2013, 3:47 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> As summary. Qt's Locale QML bindings do not provide simple "time with seconds" and "time without seconds", it supports only "short" or "long" format, where long format usually contains timezone too. So I added a special function that removes the timezone from the long format.
>
> All works.
>
>
> Diffs
> -----
>
> plasma/generic/applets/digital-clock/contents/ui/DigitalClock.qml 24d9b0c
>
> Diff: http://git.reviewboard.kde.org/r/114112/diff/
>
>
> Testing
> -------
>
> Works in both show seconds and show timezone modes.
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131125/cfd83fcc/attachment.html>
More information about the Plasma-devel
mailing list