Review Request 114110: Prints time in the lower right corner

[Shantanu Tushar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114110/#review44425
-----------------------------------------------------------


Looks cool, please try to adjust the code as per the following comments. Also, make sure to add screenshots whenever you post a review which makes a UI change.


mediaelements/mediawelcome/HomeScreenFooter.qml
<http://git.reviewboard.kde.org/r/114110/#comment31765>

    This is more concise and lesser calls to getMinutes()-
    
    var minutes = d.getMinutes();
    if (minutes < 10) {
        minutes = '0' + minutes;
    }
    



mediaelements/mediawelcome/HomeScreenFooter.qml
<http://git.reviewboard.kde.org/r/114110/#comment31766>

    It is a good idea to keep all related logic at one place-
    
    var timeOfDay = hours > 12 ? 'PM' : 'AM';
    hours = hours % 12;


- Shantanu Tushar


On Nov. 25, 2013, 3:12 p.m., Oskar Jauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114110/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 3:12 p.m.)
> 
> 
> Review request for Plasma and Shantanu Tushar.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Shows time in the lower right corner in 12 hours format in the Plasma MediaCenter.
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediawelcome/HomeScreenHeader.qml 2127ce7 
>   mediaelements/mediawelcome/HomeScreenFooter.qml e6173de 
> 
> Diff: http://git.reviewboard.kde.org/r/114110/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Oskar Jauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131125/b44fcc5d/attachment-0001.html>