Review Request 113369: Port showActivityManager and add it to desktop layout

Bhushan Shah bhush94 at gmail.com
Mon Nov 25 13:26:40 UTC 2013



> On Nov. 25, 2013, 6:16 p.m., Sebastian Kügler wrote:
> > plasma/qmlpackages/desktop/contents/layout.js, line 6
> > <http://git.reviewboard.kde.org/r/113369/diff/2/?file=219179#file219179line6>
> >
> >     Let's wait with this line, we have a bunch of things to sort out wrt activities currently. Having the applet ported is definitely useful, but I'd avoid adding it to the default layout just yet.

That's why I opened review... :)


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113369/#review44387
-----------------------------------------------------------


On Nov. 22, 2013, 8:23 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113369/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2013, 8:23 p.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Port showActivitybar widget to Plasma2 and make it part of default layout,
> 
> Nothing in code but needs review because it will alter the default layout.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/CMakeLists.txt c91117a 
>   plasma/desktop/applets/showActivityManager/CMakeLists.txt 7c73001 
>   plasma/desktop/applets/showActivityManager/package/contents/ui/main.qml d56c9ab 
>   plasma/qmlpackages/desktop/contents/layout.js e535b98 
> 
> Diff: http://git.reviewboard.kde.org/r/113369/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131125/ef4d6456/attachment-0001.html>


More information about the Plasma-devel mailing list