KDE_PLATFORM_PROFILE in kde-workspace

[David Faure]

On Sunday 24 November 2013 18:26:30 Martin Graesslin wrote:
> On Sunday 24 November 2013 18:12:48 David Faure wrote:
> > kde-workspace still uses this cmake variable, set by kdelibs,
> > but KF5 itself doesn't use it at all.
> > 
> > What's the plan about this in kde-workspace?
> > It's currently used to disable the compilation of a large number of
> > applications (kdm, systemsettings, klipper, krunner, etc.)
> > 
> > I can just move the bit of cmake logic from kdelibs to kde-workspace, but
> > if you have bigger plans, please let me know.
> > 
> > plasma itself doesn't use this cmake var (anymore).
> 
> my opinion is to remove the logic as I think we just want to have everything
> available to make a good runtime switching experience between the various
> shells.

OK. What should happen to this, from kwin/CMakeLists.txt?


if(${KDE_PLATFORM_PROFILE} STREQUAL "Desktop")
   option(KWIN_PLASMA_ACTIVE "Enable building KWin for Plasma Active." OFF)
else()
   option(KWIN_PLASMA_ACTIVE "Enable building KWin for Plasma Active." On)
endif()

# Binary name of KWin
set(KWIN_NAME "kwin")

if(KWIN_PLASMA_ACTIVE)
    set(KWIN_BUILD_DECORATIONS OFF)
    set(KWIN_BUILD_KCMS OFF)
    set(KWIN_BUILD_SCREENEDGES OFF)
    set(KWIN_BUILD_SCRIPTING ON)
    set(KWIN_BUILD_XRENDER_COMPOSITING OFF)
    set(KWIN_MOBILE_EFFECTS ON)
    set(KWIN_BUILD_WITH_OPENGLES ON)
    set(KWIN_NAME "kwinactive")
endif()

Shall I remove it all?

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5