Review Request 114059: [Pager] Avoid crashes when no windows

[Luís Gabriel Lima]

> On Nov. 23, 2013, 11:44 p.m., Luís Gabriel Lima wrote:
> > plasma/desktop/applets/pager/pager.cpp, lines 838-844
> > <http://git.reviewboard.kde.org/r/114059/diff/1/?file=219394#file219394line838>
> >
> >     Same here.
> 
> Christoph Feck wrote:
>     I wasn't sure about this one, because there is "stuff" done after the for-loop, in other words, even if the number of windows was 0.

Sorry, indeed there is stuff after the for loop. We cannot do an early return here.


- Luís Gabriel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114059/#review44289
-----------------------------------------------------------


On Nov. 24, 2013, 12:02 a.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114059/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2013, 12:02 a.m.)
> 
> 
> Review request for Plasma and Luís Gabriel Lima.
> 
> 
> Bugs: 319231, 321086 and 321389
>     http://bugs.kde.org/show_bug.cgi?id=319231
>     http://bugs.kde.org/show_bug.cgi?id=321086
>     http://bugs.kde.org/show_bug.cgi?id=321389
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> This is more of a workaround, because I did not understand why the desktop list could get empty in the first place.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/pager/model.cpp 4424e3c 
>   plasma/desktop/applets/pager/pager.cpp eb8c63c 
> 
> Diff: http://git.reviewboard.kde.org/r/114059/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131124/c1a3afb4/attachment-0001.html>