Review Request 114059: [Pager] Avoid crashes when no windows

[Luís Gabriel Lima]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114059/#review44289
-----------------------------------------------------------



plasma/desktop/applets/pager/model.cpp
<http://git.reviewboard.kde.org/r/114059/#comment31693>

    I'd prefer to use and early return here too.
    
    if (!windows)
        return;



plasma/desktop/applets/pager/pager.cpp
<http://git.reviewboard.kde.org/r/114059/#comment31694>

    Same here.


- Luís Gabriel Lima


On Nov. 23, 2013, 11:32 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114059/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2013, 11:32 p.m.)
> 
> 
> Review request for Plasma and Luís Gabriel Lima.
> 
> 
> Bugs: 319231, 321086 and 321389
>     http://bugs.kde.org/show_bug.cgi?id=319231
>     http://bugs.kde.org/show_bug.cgi?id=321086
>     http://bugs.kde.org/show_bug.cgi?id=321389
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> This is more of a workaround, because I did not understand why the desktop list could get empty in the first place.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/pager/model.cpp 4424e3c 
>   plasma/desktop/applets/pager/pager.cpp eb8c63c 
> 
> Diff: http://git.reviewboard.kde.org/r/114059/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131123/b65c97e8/attachment-0001.html>