Review Request 113124: MouseEventListener: Don't process event from children multiple times.

Nicolás Alvarez nicolas.alvarez at gmail.com
Mon Nov 18 23:40:29 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113124/
-----------------------------------------------------------

(Updated Nov. 18, 2013, 8:40 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Bugs: 316546
    http://bugs.kde.org/show_bug.cgi?id=316546


Repository: kde-runtime


Description
-------

MouseEventListener: Don't process event from children multiple times.

If an event passed through multiple visually-overlapping children of
MouseEventListener, the event filter was processing the event every time.
For example, this caused problems for the KMix icon in the tray, which
would trigger volume changes three times for every mouse wheel event.

BUG:316546


Diffs
-----

  plasma/declarativeimports/qtextracomponents/mouseeventlistener.cpp 36530e075dc52348f32032c32457a090b904c3b9 

Diff: http://git.reviewboard.kde.org/r/113124/diff/


Testing
-------

The KMix problem is gone, each mouse wheel step now changes the volume by the appropriate amount.


Thanks,

Nicolás Alvarez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131118/f64faaa9/attachment.html>


More information about the Plasma-devel mailing list