Review Request 113260: Port KTimeZoned to Qt5/KF5

[Christoph Feck]

> On Nov. 12, 2013, 10:39 a.m., Commit Hook wrote:
> > This review has been submitted with commit 53e8e439af2483c86b21ad4d53ffe4da622e8c44 by Martin Klapetek to branch frameworks.
> 
> Christoph Feck wrote:
>     Locally, I get this error:
>     
>     AUTOMOC: error: process for /local/build/kf5/runtime/ktimezoned/ktimezoned.moc failed:
>     /local/git/KDE/base/kde-runtime-frameworks/ktimezoned/ktimezoned.cpp:35: Error: Plugin Metadata file "ktimezoned.json" does not exist. Declaration will be ignored
>     
>     moc failed...
>     make[2]: *** [ktimezoned/CMakeFiles/kded_ktimezoned_automoc] Error 1
>     make[2]: Target `ktimezoned/CMakeFiles/kded_ktimezoned_automoc.dir/build' not remade because of errors.
>     make[1]: *** [ktimezoned/CMakeFiles/kded_ktimezoned_automoc.dir/all] Error 2
>     
>     Any idea?
> 
> Martin Klapetek wrote:
>     I know other folks seen this too, last time I've heard it might be a "race condition" issue with -j>1 build (the json file gets generated only after building the file that's actually including it). I think Aurelien was looking into that, dunno if he made any progress though.

It's indeed a "use before it's built", because when I run try to build it again (on the same build dir) it works. A clean build, however, reliably reproduces this error, even without using "-j" make option.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113260/#review43507
-----------------------------------------------------------


On Nov. 12, 2013, 10:39 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113260/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2013, 10:39 a.m.)
> 
> 
> Review request for KDE Runtime, KDE Frameworks, Plasma, and John Layt.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> Originally I wanted to port KTimeZoned 1:1 to Qt5/KF5, but then I found out that all the stuff KTZD was doing was added in QTimeZone, that includes reading correct system files/env variables to obtain the timezone and returning the proper system zone (KTZD did all this by itself). It also doesn't need to parse the timezone files itself or watch for their changes as QTimeZone objects are not stored.
> 
> So now it's just a thin module watching /etc/timezone (used by Debian-based distros) and /etc/localtime (used by eg. Fedora or Suse, but also by Debian in conjunction with /etc/timezone) for changes and if it detects a change, it checks if the new timezone is really different and if it is, it sends out a DBus signal "timeZoneChange". I changed it from "configChanged" as I think "timeZoneChanged" makes way more sense.
> 
> I didn't touch the Windows part as I have no way to test, would be nice if someone could help with that.
> 
> EDIT: I removed the other two DBus signals which were not used and I'm unsure KTZD is the correct place for that now anyway. The only usage in KSystemTimeZone can be replaced by own KDirWatch instance.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a5ec93d 
>   ktimezoned/CMakeLists.txt bafc85e 
>   ktimezoned/ktimezoned.h ff21807 
>   ktimezoned/ktimezoned.cpp f380c09 
>   ktimezoned/ktimezoned_win.h 26e21cc 
>   ktimezoned/ktimezoned_win.cpp cadfe3a 
>   ktimezoned/ktimezonedbase.h ca00aca 
>   ktimezoned/org.kde.KTimeZoned.xml daaa0b7 
> 
> Diff: http://git.reviewboard.kde.org/r/113260/diff/
> 
> 
> Testing
> -------
> 
> Tested by changing the timezone in different ways, change was detected and signalled out.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131116/1c178af1/attachment-0001.html>