Review Request 113700: Do not add dialog to DialogShadows before it became visible at least once

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113700/#review43201
-----------------------------------------------------------

Ship it!


good catch.. doesn't look easy to catch ;)

- Marco Martin


On Nov. 7, 2013, 8:59 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113700/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2013, 8:59 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Calling DialogShadows::self()->addWindow(...) will create the low level window.
> If this is called before the property windowFlags is evaluated the window flag
> X11BypassWindowManagerHint has no effect as that one must be present when the
> window is created through the low level xcb call.
> 
> This was breaking declarative KWin scripts as KWin's windows need to have the
> X11BypassWindowManagerHint.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/dialog.cpp ba43404 
> 
> Diff: http://git.reviewboard.kde.org/r/113700/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131107/ed6fc1dd/attachment.html>