Review Request 113659: system-monitor plasmoid: respect settings from js code
Eike Hein
hein at kde.org
Tue Nov 5 21:04:51 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113659/#review43124
-----------------------------------------------------------
Avoiding recreating applets unnecessary is a good improvement, but in that event you need to call configChanged() on the child applets to have them reread their config.
- Eike Hein
On Nov. 5, 2013, 8:58 p.m., Sergei Lopatin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113659/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2013, 8:58 p.m.)
>
>
> Review request for Plasma and Eike Hein.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> Added ability to system-monitor plasmoid to set configuration from js code. Something like this:
> a = activityForScreen(0)
> if (a) {
> var applet = a.addWidget("system-monitor_applet")
> applet.writeConfig("applets", "sm_ram,sm_cpu")
> }
>
>
> Diffs
> -----
>
> plasma/generic/applets/system-monitor/system-monitor.h f8a2975
> plasma/generic/applets/system-monitor/system-monitor.cpp 1705a99
>
> Diff: http://git.reviewboard.kde.org/r/113659/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergei Lopatin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131105/4b69b07f/attachment.html>
More information about the Plasma-devel
mailing list