Review Request 110608: Add support for keyboard backlight handling to the powermanagement dataengine

Marco Martin notmart at gmail.com
Sun May 26 09:40:39 UTC 2013



> On May 26, 2013, 9:39 a.m., Marco Martin wrote:
> > Ship It!

At least for the plasma part, some feedback by solid people would be appreciated as well ;)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110608/#review33143
-----------------------------------------------------------


On May 23, 2013, 9:13 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110608/
> -----------------------------------------------------------
> 
> (Updated May 23, 2013, 9:13 a.m.)
> 
> 
> Review request for Plasma and Solid.
> 
> 
> Description
> -------
> 
> This patch adds support for keyboard backlight handling to the powermanagement dataengine.
> 
> It is similar to the backlight handling. Allows setting and getting they keyboard brightness and checking whether it is supported at all.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 319a17c 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 4b184fa 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 3b974ab 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp 6f90006 
>   plasma/generic/dataengines/powermanagement/powermanagementservice.operations 533c00a 
> 
> Diff: http://git.reviewboard.kde.org/r/110608/diff/
> 
> 
> Testing
> -------
> 
> Adjusting keyboard brightness from the battery monitor so coooool.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130526/211d324a/attachment-0001.html>


More information about the Plasma-devel mailing list