Review Request 110621: Drag and Drop feature to swap items in playlist added.

[Shantanu Tushar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110621/#review33070
-----------------------------------------------------------


Thanks for the patch :)


libs/mediacenter/playlistmodel.h
<http://git.reviewboard.kde.org/r/110621/#comment24453>

    better names would be firstIndex and secondIndex



libs/mediacenter/playlistmodel.cpp
<http://git.reviewboard.kde.org/r/110621/#comment24454>

    resetting the whole model is an expensive operation. Its better to use beginMoveRows for the source index.
    http://qt-project.org/doc/qt-4.8/qabstractitemmodel.html#beginMoveRows


- Shantanu Tushar


On May 23, 2013, 7:36 p.m., saurabh jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110621/
> -----------------------------------------------------------
> 
> (Updated May 23, 2013, 7:36 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Description
> -------
> 
> Reordering of the songs in the playlist is now possible using this patch. Just drag and drop the item to the desired place (where you want to replace it with the item at desired location). 
> 
> 
> Diffs
> -----
> 
>   libs/mediacenter/playlistmodel.h 2c1dc6b 
>   libs/mediacenter/playlistmodel.cpp 40b490c 
>   mediaelements/playlist/PlaylistDelegate.qml b1e6f40 
> 
> Diff: http://git.reviewboard.kde.org/r/110621/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> saurabh jain
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130524/ffd06087/attachment.html>