Review Request 110467: Plasma Wallpaper BackgroundListModel: Avoid using KFileMetaInfo

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110467/
-----------------------------------------------------------

(Updated May 17, 2013, 6:02 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Description
-------

    Plasma Wallpaper BackgroundListModel: Avoid using KFileMetaInfo
    
    1. The Xesam width and height properties are never returned by strigi
    and haven't been returned for a very very long time. It currently
    returns the nfo:width and nfo:height property instead.
    
    2. KFileMetadataWidget is blocking and blocks while it is calculating
    the height and width. It is better to open the file and calculate it in
    another thread as done by the ImageSizeFinder
    
    3. QImage in more reliable and actively maintained in contrast to
    strigi.


Diffs
-----

  plasma/generic/wallpapers/image/backgroundlistmodel.cpp c4093a7 

Diff: http://git.reviewboard.kde.org/r/110467/diff/


Testing
-------


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130517/40fd65b5/attachment.html>