Review Request 110420: Bugfix for bug #311364

Romário Rios luizromario at gmail.com
Fri May 17 11:18:37 UTC 2013



> On May 17, 2013, 7:33 a.m., Aaron J. Seigo wrote:
> > the point of notifications are, obviously, to inform the user. if it hides as soon as something else is interacted with, the user will miss many (even most) notifications that appear while they are using the computer. obviously not the goal.
> > 
> > i'd be fine a change that makes it a passive popup when the user purposefully opens it up themselves (so, the default can be passive) but when the window is automatically shown then it should *not* be a passive popup but instead keep showing until it times out and automatically retracts or the user closes it purposefully. (at which point it could go back to being a passive popup)
> 
> Romário Rios wrote:
>     I'll confirm that when I get home, but the patch changes the behavior of the notifications history (i.e., the thing that appears when we click the notifications icon), not that of the notifications popup. Well, I wrote "popup" in the testing done section, so, my bad for confusing things. I'll try to make it clearer.

Just checked and now I can confirm that the popup behavior remains inaltered.


- Romário


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110420/#review32683
-----------------------------------------------------------


On May 17, 2013, 8:26 a.m., Romário Rios wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110420/
> -----------------------------------------------------------
> 
> (Updated May 17, 2013, 8:26 a.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Description
> -------
> 
> Fixes bug #311364. I'm not entirely sure if that's a bug or a feature, but since it's a simple two-liner, I figured I'd just drop the diff and let you decide.
> 
> 
> This addresses bug 311364.
>     http://bugs.kde.org/show_bug.cgi?id=311364
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/notifications/contents/ui/main.qml e867517 
> 
> Diff: http://git.reviewboard.kde.org/r/110420/diff/
> 
> 
> Testing
> -------
> 
> After the notifications icon is clicked and the history pops up, it hides when it goes out of focus if no jobs are running, but doesn't hide otherwise.
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130517/f7bb6806/attachment.html>


More information about the Plasma-devel mailing list