Review Request 110475: Fixed::Bug 319626 - Can't remove an another song from playlist without stopping the current media.

Shantanu Tushar shantanu at kde.org
Thu May 16 17:15:48 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110475/#review32660
-----------------------------------------------------------

Ship it!


Looks good. Should I commit this for you?


mediaelements/playlist/PlaylistDelegate.qml
<http://git.reviewboard.kde.org/r/110475/#comment24294>

    don't use comments, just remove the line


- Shantanu Tushar


On May 16, 2013, 5:07 p.m., Akshay Ratan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110475/
> -----------------------------------------------------------
> 
> (Updated May 16, 2013, 5:07 p.m.)
> 
> 
> Review request for Plasma, Marco Martin, Shantanu Tushar, and Sinny Kumari.
> 
> 
> Description
> -------
> 
> Fixed bug 319626 ( https://bugs.kde.org/show_bug.cgi?id=319626) . Now, in the media playlist, "remove" sign is shown on every song , so the user has to just click that "sign" instead of clicking the song which earlier stopped the media.
> 
> So basically now the current media is not stopped when deleting an item from a playlist.
>  
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=319626.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=319626
> 
> 
> Diffs
> -----
> 
>   mediaelements/playlist/PlaylistDelegate.qml 449a0aa 
> 
> Diff: http://git.reviewboard.kde.org/r/110475/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Akshay Ratan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130516/84f6eb2b/attachment.html>


More information about the Plasma-devel mailing list