Review Request 110453: Order tasks by activity in tasks applet

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110453/#review32645
-----------------------------------------------------------

Ship it!


Looks good, and a nice feature to have in there.


libs/taskmanager/strategies/activitysortingstrategy.cpp
<http://git.reviewboard.kde.org/r/110453/#comment24286>

    in Qt5, "const QString &activity" is a little more performant; QString is cheap to create but still isn't POD. in Qt5, this might have changed to be irrelevant. just a little side-note, one that probably won't matter here given the # of entries to be iterated over :)


- Aaron J. Seigo


On May 15, 2013, 5:34 p.m., José Millán Soto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110453/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 5:34 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> A new ordering strategy ActivitySortingStrategy was created. This strategy will
> order elements by the activities they are available on.
> 
> The ones which are available in the activities with more tasks will be
> displayed first.
> 
> 
> Diffs
> -----
> 
>   libs/taskmanager/CMakeLists.txt 375a0d6 
>   libs/taskmanager/groupmanager.h f7e9878 
>   libs/taskmanager/groupmanager.cpp 45c15a9 
>   libs/taskmanager/strategies/activitysortingstrategy.h PRE-CREATION 
>   libs/taskmanager/strategies/activitysortingstrategy.cpp PRE-CREATION 
>   plasma/desktop/applets/tasks/tasks.cpp 0a86dcf 
> 
> Diff: http://git.reviewboard.kde.org/r/110453/diff/
> 
> 
> Testing
> -------
> 
> Three activities were created (called Activity 1, 2 and 3), and several dialogs were created (the activities to which each dialog were assigned are marked by the numbers after the "A" in the title).
> Screenshot 1 shows the task manager running in plasma-windowed with grouping disabled, and the task manager being assigned to all activities. The second screenshot shows the task manager if the task manager is assigned only to Activity 1, an instance of xmessage is assigned to activity 2 and the grouping by program is active.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot 1
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/15/img1.png
> Screenshot 2
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/15/img2.png
> 
> 
> Thanks,
> 
> José Millán Soto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130516/f2ceaed8/attachment-0001.html>