Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alpha channel

[Michał Dutkiewicz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110427/
-----------------------------------------------------------

(Updated May 15, 2013, 4:50 p.m.)


Review request for Plasma, Aaron J. Seigo and Marco Martin.


Changes
-------

Added unit test and removed trimmed() for RGBA values (seems to be not needed).


Description
-------

This patch aims to allow Plasma::ConfigLoader to properly load default values of QColor that contains alpha channel (bug #318504).
Apparently constructor of QColor which takes QString as value fails to detect and properly (QColor with alpha channel is handled properly by KConfigGroup).


This addresses bug 318504.
    http://bugs.kde.org/show_bug.cgi?id=318504


Diffs (updated)
-----

  plasma/configloader.cpp 5c67474 
  plasma/tests/configloadertest.h ed5a32c 
  plasma/tests/configloadertest.cpp 6737cae 
  plasma/tests/configloadertest.xml 13ccd32 

Diff: http://git.reviewboard.kde.org/r/110427/diff/


Testing (updated)
-------

Compiles, unit test passes (assuming that it was done correctly ;-)).


Thanks,

Michał Dutkiewicz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130515/167d6d5a/attachment.html>