Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alpha channel

[Michał Dutkiewicz]

> On May 14, 2013, 8:50 p.m., Aaron J. Seigo wrote:
> > plasma/configloader.cpp, lines 204-205
> > <http://git.reviewboard.kde.org/r/110427/diff/1/?file=143707#file143707line204>
> >
> >     '/' but then ','
> >     
> >     which is it (and what color format saves like that?)

True, I have no idea how it got misplaced, it was correct in original code (standalone one).


- Michał


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110427/#review32521
-----------------------------------------------------------


On May 14, 2013, 8:55 p.m., Michał Dutkiewicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110427/
> -----------------------------------------------------------
> 
> (Updated May 14, 2013, 8:55 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo and Marco Martin.
> 
> 
> Description
> -------
> 
> This patch aims to allow Plasma::ConfigLoader to properly load default values of QColor that contains alpha channel (bug #318504).
> Apparently constructor of QColor which takes QString as value fails to detect and properly (QColor with alpha channel is handled properly by KConfigGroup).
> 
> 
> This addresses bug 318504.
>     http://bugs.kde.org/show_bug.cgi?id=318504
> 
> 
> Diffs
> -----
> 
>   plasma/configloader.cpp 5c67474 
> 
> Diff: http://git.reviewboard.kde.org/r/110427/diff/
> 
> 
> Testing
> -------
> 
> Failed to compile kdelibs due to unrelated errors (even before applying patch...).
> 
> 
> Thanks,
> 
> Michał Dutkiewicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130514/abc9fdb0/attachment.html>