Review Request 110406: Expose more battery properties to the Power Management dataengine

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110406/#review32520
-----------------------------------------------------------

Ship it!


Ship It!

- Aaron J. Seigo


On May 12, 2013, 1:06 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110406/
> -----------------------------------------------------------
> 
> (Updated May 12, 2013, 1:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Depends on Review 110384
> 
> This patch makes exposes more battery properties to the Power Management dataengine, namely:
> 
> - Name: This is the device name of the battery. It will usually be "Unknown Battery" but if you eg. attach a mouse (tested with Apple Magic Mouse) or another battery device with a name, it will show this. This will eventually allow the battery monitor to not just show Battery 1, Battery 2, but actually the device name.
> 
> - Type: The type of battery, such as Primary (for internal notebook batteries) or Mouse. This could also be useful to show eg. a device icon in the battery monitor.
> 
> - Power Supply: If the battery is actually powering the machine (ie. notebook battery) or coming from one of the peripherals (Mouse, Keyboard, ..). This will eventually allow the battery monitor to disregard those devices when calculating overall battery percentage, or group peripheral devices visually separated, or so. 
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp d1b9519 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 35e9ecf 
> 
> Diff: http://git.reviewboard.kde.org/r/110406/diff/
> 
> 
> Testing
> -------
> 
> Tested with Apple Magic Mouse and it properly reported its name and power supply state. The Type property is somewhat unreliable as UPower also considered the mouse as Primary battery. But the Is Power Supply property was correct and that's the prevailing one.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130514/a8c3d23f/attachment-0001.html>