Review Request 110413: Show in the tasks applet the activities a task is available on

[Eike Hein]

> On May 13, 2013, 11:18 a.m., Eike Hein wrote:
> > This isn't a call to reject this patch (which I think is a nice idea), but FWIW: The Task Manager widget is still intended to be replaced by a QML rewrite before feature freeze, and the QML bindings to Plasma's tooltip primitive currently don't allow for a lot in the way of layouting custom content, so I might not be able to recreate this too easily there, specifally having a line break between the two bits of info (unless the tooltip subtext prop accepts rich text). That said since I already had to fork the QML ToolTip component to get window preview thumbnails in there, I guess I could always fork my way further out of that dilemma.
> > 
> > In libplasma2 QML ToolTips are fortunately going to be much more flexible, ending the need for a fork.
> 
> Eike Hein wrote:
>     Turns out that throwing a <br/> in there is no problem, so this is easy to sync up with after all.
> 
> José Millán Soto wrote:
>     If that's the case, I suppose I should do a commit which includes the changes in TaskItem but not the changes in WindowTaskItem.
>     Am I right?

Nah, I don't think you need to bother. I don't think the lib change is going to cause any merge conflicts when I rebase my branch onto master and the widget change doesn't affect me since the old C++ codebase just goes out the window. And it probably makes sense to commit the widget change even now, since it's useful testing by exercising the new lib API you add, or in case I get unexpectedly hit by a bus :).


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110413/#review32437
-----------------------------------------------------------


On May 13, 2013, 11:10 a.m., José Millán Soto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110413/
> -----------------------------------------------------------
> 
> (Updated May 13, 2013, 11:10 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patch adds information about the activities on which a task is available to the tooltip.
> Two methods to obtain information about the activities a task is available, activities and activityNames, where added to TaskManager::TaskItem.
> Depending whether the applet is configured to show tasks which are not available in the current activity or not, the information displayed will be different.
> If the applet is configured to show only tasks in current activity, only the tasks which are also available in other activities will have this information in the tooltip.
> 
> 
> This addresses bug 307163.
>     http://bugs.kde.org/show_bug.cgi?id=307163
> 
> 
> Diffs
> -----
> 
>   libs/taskmanager/taskitem.h 35606e2 
>   libs/taskmanager/taskitem.cpp c9613c9 
>   plasma/desktop/applets/tasks/windowtaskitem.cpp f840076 
> 
> Diff: http://git.reviewboard.kde.org/r/110413/diff/
> 
> 
> Testing
> -------
> 
> In order to test this patch, three activities (called "Activity 1", "Activity 2" and "Activity 3") were created.
> Various instances of KDialog were created, all of them in desktop 1, and they were assigned to various activities (The title of the dialog was set to AxDi, where x are the activities on which the dialog will be available).
> All screenshots were taken on activity 1.
> Screenshots 1 to 3 were taken with the taskbar configured to display tasks in all activities but only in desktop 1. Screenshots 4 to 6 were taken with the configuration to show tasks only in current activity. Screenshot 7 was taken with the taskbar displaying all tasks from all desktops. Screenshot 8 was created with the taskbar configured to group elements by program (activity information is not yet available).
> 
> 
> File Attachments
> ----------------
> 
> Screenshot 1
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot1.png
> Screenshot 2
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot2.png
> Screenshot 3
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot3.png
> Screenshot 4
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot4.png
> Screenshot 5
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot5.png
> Screenshot 6
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot6.png
> Screenshot 7
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot7.png
> Screenshot 8
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot8.png
> 
> 
> Thanks,
> 
> José Millán Soto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130513/3f2011dc/attachment.html>