Review Request 110382: Fix a crash that happens when you close some apps

Aaron J. Seigo aseigo at kde.org
Fri May 10 14:51:49 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110382/#review32319
-----------------------------------------------------------

Ship it!


please fix the coding style, and then commit. cheers :)


plasma/private/dialogshadows.cpp
<http://git.reviewboard.kde.org/r/110382/#comment24042>

    needs parens (and proper indentation)
    


- Aaron J. Seigo


On May 10, 2013, 12:57 p.m., Anne-Marie Mahfouf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110382/
> -----------------------------------------------------------
> 
> (Updated May 10, 2013, 12:57 p.m.)
> 
> 
> Review request for Plasma and Aurélien Gâteau.
> 
> 
> Description
> -------
> 
> This patch fixes a crash reported in https://bugs.kde.org/show_bug.cgi?id=319137. Should also be backported to 4.10 branch.
> 
> 
> This addresses bug 319137.
>     http://bugs.kde.org/show_bug.cgi?id=319137
> 
> 
> Diffs
> -----
> 
>   plasma/private/dialogshadows.cpp b54fb1a 
> 
> Diff: http://git.reviewboard.kde.org/r/110382/diff/
> 
> 
> Testing
> -------
> 
> Tested personally and tested by several other people, see the bug report. It fixes the crash. 
> 
> 
> Thanks,
> 
> Anne-Marie Mahfouf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130510/40aff2fe/attachment-0001.html>


More information about the Plasma-devel mailing list