Review Request 110290: Share data engine - add im9.eu images upload service

[Sebastian Kügler]

> On May 4, 2013, midnight, Sebastian Kügler wrote:
> > plasma/generic/dataengines/share/backends/im9/CMakeLists.txt, line 7
> > <http://git.reviewboard.kde.org/r/110290/diff/1/?file=141951#file141951line7>
> >
> >     install the directory, not the individual files. That way, when someone adds a file (for example by splitting out something from main.js), the CMakeLists.txt files doesn't need adjustment. It's also more in line with how we do it in the rest of Plasma.
> 
> Michał Dutkiewicz wrote:
>     I've modified it to install whole contents directory but failed to use single command that would also install metadata.desktop, without installing build files...

That's correct, you don't get under two lines this way. In Plasma2 we have a macro to help with that. In Plasma1, a two-lined installation statement is fine.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110290/#review31983
-----------------------------------------------------------


On May 4, 2013, 1:50 p.m., Michał Dutkiewicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110290/
> -----------------------------------------------------------
> 
> (Updated May 4, 2013, 1:50 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Artur Duque de Souza, and Marco Martin.
> 
> 
> Description
> -------
> 
> This patch adds support for im9.eu images upload service to share data engine.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/share/backends/CMakeLists.txt 30695d3 
>   plasma/generic/dataengines/share/backends/im9/CMakeLists.txt PRE-CREATION 
>   plasma/generic/dataengines/share/backends/im9/contents/code/main.js PRE-CREATION 
>   plasma/generic/dataengines/share/backends/im9/metadata.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110290/diff/
> 
> 
> Testing
> -------
> 
> Tested with KDE 4.10, works fine.
> 
> 
> Thanks,
> 
> Michał Dutkiewicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130504/a86582e0/attachment.html>