Review Request 110288: Checks if an optional field was instantiated before accessing it

Denis Falqueto denisfalqueto at gmail.com
Fri May 3 20:38:53 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110288/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

The private field m_konsolewidget is initialized only on some specific cases, so it should be accessed with caution. But there are some places in witch it's being used without checking if it was instantiated or not. This patch fixes those accesses, by checking if it is instantiated or not.


This addresses bug 319291.
    http://bugs.kde.org/show_bug.cgi?id=319291


Diffs
-----

  plasmate/mainwindow.cpp 1ef5a81 

Diff: http://git.reviewboard.kde.org/r/110288/diff/


Testing
-------

I've created a data engine in python successfully.


Thanks,

Denis Falqueto

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130503/bac566f8/attachment-0001.html>


More information about the Plasma-devel mailing list