Review Request 109857: Add the "theme" directory to the plasmoid directory structure

Marco Martin notmart at gmail.com
Fri May 3 12:03:42 UTC 2013



> On April 9, 2013, 7:11 p.m., Commit Hook wrote:
> > This review has been submitted with commit 24c26aefacff274ac52d773e39fbbfa3b458e213 by Alex Merry to branch master.

Has this ever been ported to plasma-framework?

and, it currently breaks unit tests


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109857/#review30807
-----------------------------------------------------------


On April 9, 2013, 7:11 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109857/
> -----------------------------------------------------------
> 
> (Updated April 9, 2013, 7:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This adds an extra step to the lookup of SVG images created with the Svg() global function: after looking in images/ in the plasmoid and then in the desktop theme, it looks in theme/$DESKTOP_THEME_NAME and then theme/ in the plasmoid.
>     
> This allows plasmoid authors to add images that they want to allow theme authors to override.
> 
> 
> Diffs
> -----
> 
>   plasma/private/packages.cpp 1f346cc8af84ae10e4e7b878cf8c3a63c98c3509 
> 
> Diff: http://git.reviewboard.kde.org/r/109857/diff/
> 
> 
> Testing
> -------
> 
> See RR 109859.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130503/5795ee3e/attachment.html>


More information about the Plasma-devel mailing list