Review Request 109773: New runner that translates words and sentences via Google Translate.

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109773/#review30004
-----------------------------------------------------------


I'm looking forward to use this runner.

Have you thought about adding another keyword to query all supported languages?


runners/translator/translator.cpp
<http://git.reviewboard.kde.org/r/109773/#comment22369>

    you are missing the > after the email address (also in the other copyright header)



runners/translator/translator.cpp
<http://git.reviewboard.kde.org/r/109773/#comment22370>

    I would suggest to turn the logic around:
    if (!ok) {
        return;
    }
    
    the code following has many indentation levels and that's just one level which is not really needed.



runners/translator/translator.cpp
<http://git.reviewboard.kde.org/r/109773/#comment22376>

    here you could do the same:
    if (list0.isEmpty()) {
        continue;
    }



runners/translator/translator.cpp
<http://git.reviewboard.kde.org/r/109773/#comment22374>

    using or is rather uncommon in KDE code. I would suggest to use ||



runners/translator/translator.cpp
<http://git.reviewboard.kde.org/r/109773/#comment22375>

    same for and



runners/translator/translator.cpp
<http://git.reviewboard.kde.org/r/109773/#comment22371>

    nitpick: QList<int>



runners/translator/translator.cpp
<http://git.reviewboard.kde.org/r/109773/#comment22372>

    nitpick: trailing whitespaces



runners/translator/translatorjob.cpp
<http://git.reviewboard.kde.org/r/109773/#comment22373>

    isn't that a rather generic user agent?


- Martin Gräßlin


On March 28, 2013, 12:14 p.m., David Baum wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109773/
> -----------------------------------------------------------
> 
> (Updated March 28, 2013, 12:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> The Runner uses the Google Translate Homepage and supports all languages provided by Google. It doesn't use the API, because it's not free of charge. 
> 
> 
> Diffs
> -----
> 
>   runners/CMakeLists.txt bb4b491b10e6fef8183a66f55f5d5832dd7bc41a 
>   runners/translator/CMakeLists.txt PRE-CREATION 
>   runners/translator/plasma-runner-translator.desktop PRE-CREATION 
>   runners/translator/translator.h PRE-CREATION 
>   runners/translator/translator.cpp PRE-CREATION 
>   runners/translator/translatorjob.h PRE-CREATION 
>   runners/translator/translatorjob.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Baum
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130328/afc3a3cc/attachment-0001.html>