Review Request 109711: Fixes a bug in the KDE dataengine to use the POST method instead of GET which allows large text to be sent to the server

Aaron J. Seigo aseigo at kde.org
Tue Mar 26 19:58:48 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109711/#review29910
-----------------------------------------------------------

Ship it!


Ship It!

- Aaron J. Seigo


On March 25, 2013, 6:50 p.m., Bhaskar Kandiyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109711/
> -----------------------------------------------------------
> 
> (Updated March 25, 2013, 6:50 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Fixes a bug where the default text engine 'kde' fails when pasting text longer than 513/741 characters in the PasteBin widget.
> The problem is that the generic dataengine 'kde' uses a GET request to send data to the http://paste.kde.org server which does not allow large text to be sent to the server.
> This patch changes the GET request to a POST request which fixes the bug.
>  
> Bug Report: https://bugs.kde.org/show_bug.cgi?id=289647
> 
> 
> This addresses bug 289647.
>     http://bugs.kde.org/show_bug.cgi?id=289647
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/share/backends/kde/contents/code/main.js 600950d 
> 
> Diff: http://git.reviewboard.kde.org/r/109711/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bhaskar Kandiyal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130326/1e01725c/attachment.html>


More information about the Plasma-devel mailing list