Review Request 109339: Delete the old konsoleWidget when loading a new project.

Tianyu Zhu tian.tian098 at gmail.com
Sat Mar 23 01:49:20 UTC 2013



> On March 15, 2013, 8:13 p.m., Giorgos Tsiapaliokas wrote:
> > any updates on this one?

It seems I forgot push the "Publish" button, my bad!


- Tianyu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109339/#review29293
-----------------------------------------------------------


On March 7, 2013, 2:10 p.m., Tianyu Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109339/
> -----------------------------------------------------------
> 
> (Updated March 7, 2013, 2:10 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> If the old konsoleWidget is not deleted when loading a new project, it shows up along with a new one in the project view.
> This also fixes a memory leak.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=316276.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=316276
> 
> 
> Diffs
> -----
> 
>   plasmate/mainwindow.cpp 13234ec 
> 
> Diff: http://git.reviewboard.kde.org/r/109339/diff/
> 
> 
> Testing
> -------
> 
> It works on my machine: Thinkpad T520, Kubuntu 12.10, KDE 4.10.1
> 
> 
> Thanks,
> 
> Tianyu Zhu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130323/3e33bc77/attachment-0001.html>


More information about the Plasma-devel mailing list