Review Request 109670: Minor fixes to assetimporters

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109670/#review29771
-----------------------------------------------------------

Ship it!


Ship It!

- Aaron J. Seigo


On March 23, 2013, 5:07 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109670/
> -----------------------------------------------------------
> 
> (Updated March 23, 2013, 5:07 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> * this patch fixes this cmake warning
> 
> CMake Warning (dev) in CMakeLists.txt:
>   No cmake_minimum_required command is present.  A line of code such as
> 
>     cmake_minimum_required(VERSION 2.8)
> 
>   should be added at the top of the file.  The version specified may be lower
>   if you wish to support older CMake versions for this project.  For more
>   information run "cmake --help-policy CMP0000".
> This warning is for project developers.  Use -Wno-dev to suppress it.
> 
> * removes the duplicated find_package(Qt4 REQUIRED)
> 
> *and s/m_channelsCatalog(ChannelsCatalog(channelsCatalogPath))/m_channelsCatalog(channelsCatalogPath)/
> 
> 
> Diffs
> -----
> 
>   assetimporters/CMakeLists.txt bdf1380 
>   assetimporters/database-common/database.cpp 6871358 
>   assetimporters/kdeartwork-wallpapers/CMakeLists.txt bc94023 
>   assetimporters/obs/CMakeLists.txt c2beeac 
>   assetimporters/projectgutenberg/CMakeLists.txt 5f902ce 
> 
> Diff: http://git.reviewboard.kde.org/r/109670/diff/
> 
> 
> Testing
> -------
> 
> I did a clean install and it compiled successfully
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130323/9785f423/attachment.html>