Review Request 109641: Fix border detection in Plasma dialogs

Commit Hook null at kde.org
Sat Mar 23 16:35:34 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109641/#review29762
-----------------------------------------------------------


This review has been submitted with commit a88fec10e0ef2dd73f08c6ef3c912a16cf2f85c7 by Aleix Pol to branch master.

- Commit Hook


On March 21, 2013, 5:41 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109641/
> -----------------------------------------------------------
> 
> (Updated March 21, 2013, 5:41 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> I had some problems with plasma dialogs borders, they appeared arbitrarily.
> After a good couple of hours of debugging, I found out that there was some really weird processing of the available region.
> 
> This patch removes this processing and uses QRegion itself to figure out if the border has to be painted. It seems to work fine.
> 
> 
> Diffs
> -----
> 
>   plasma/dialog.cpp 038444c 
> 
> Diff: http://git.reviewboard.kde.org/r/109641/diff/
> 
> 
> Testing
> -------
> 
> Played with it, together with the ktp-chat plasmoid
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130323/bc8ada49/attachment.html>


More information about the Plasma-devel mailing list