Review Request 109340: Use default background colours for the konsolepreviewer

[Giorgos Tsiapaliokas]

> On March 15, 2013, 8:13 p.m., Giorgos Tsiapaliokas wrote:
> > any updates on this one?
> 
> Tianyu Zhu wrote:
>     Sorry, I've had a hectic couple of weeks (school, you know). I haven't contributed to KDE before so I'll see what I can figure out from the wiki.

>I haven't contributed to KDE before so I'll see what I can figure out from the wiki.

If you have any questions, you can always ask on the irc, probably I will also be there.


- Giorgos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109340/#review29294
-----------------------------------------------------------


On March 11, 2013, 1:31 p.m., Tianyu Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109340/
> -----------------------------------------------------------
> 
> (Updated March 11, 2013, 1:31 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> - Deleted lines hard-coding the background of the konsolepreviwer to white.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=316274.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=316274
> 
> 
> Diffs
> -----
> 
>   plasmate/konsole/konsolepreviewer.h 543ff77 
>   plasmate/konsole/konsolepreviewer.cpp 05d426e 
> 
> Diff: http://git.reviewboard.kde.org/r/109340/diff/
> 
> 
> Testing
> -------
> 
> Tested on Kubuntu 12.10 with KDE 4.10.1
> Tested with both the default and Krita-Dark colour scheme. In both cases, the text in the konsolepreviewer shows up well against its background.
> 
> 
> Thanks,
> 
> Tianyu Zhu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130323/672acfc5/attachment.html>