Review Request 109500: Refactor of the savesystem
Commit Hook
null at kde.org
Sat Mar 23 15:58:20 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109500/
-----------------------------------------------------------
(Updated March 23, 2013, 3:58 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Description
-------
Hello,
this patch is the refactor of the savesystem.
Also in this refactor the above bugs are being fixed.
Q: Why do we need a refactor?
A: * Before this patch in order to take the git log we did
some parsing, which wasn't nice. With this patch we use git log --pretty-format.
* There are some other changes like coding style stuff and striping \n from strings.
This addresses bugs 316202, 316724 and 316725.
http://bugs.kde.org/show_bug.cgi?id=316202
http://bugs.kde.org/show_bug.cgi?id=316724
http://bugs.kde.org/show_bug.cgi?id=316725
Diffs
-----
plasmate/savesystem/dvcsjob.cpp 288d7a6
plasmate/savesystem/gitrunner.h 50f87ab
plasmate/savesystem/gitrunner.cpp b263be6
plasmate/savesystem/timeline.h 73849d0
plasmate/savesystem/timeline.cpp 231fc46
Diff: http://git.reviewboard.kde.org/r/109500/diff/
Testing
-------
Thanks,
Giorgos Tsiapaliokas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130323/8c071835/attachment-0001.html>
More information about the Plasma-devel
mailing list