Review Request 109592: Update welcome plasmoid to PlasmaComponents buttons.
Aaron J. Seigo
aseigo at kde.org
Fri Mar 22 13:57:49 UTC 2013
> On March 22, 2013, 1:57 p.m., Aaron J. Seigo wrote:
> > Why was this marked as discarded?
> >
> > I don't think anyone even had a chance to review it .. did you run into a problem with the patch that caused you to discard it?
ah, nevermind.. i see the other review request now .. it was next in my queue :/
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109592/#review29720
-----------------------------------------------------------
On March 19, 2013, 10:24 p.m., Michael Bohlender wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109592/
> -----------------------------------------------------------
>
> (Updated March 19, 2013, 10:24 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Replace mobilecomponets buttons with PlasmaComponents buttons.
>
>
> this is my fist post to reviewboard so i hope i did everything right :)
>
>
> Diffs
> -----
>
> applets/active-welcome/contents/code/welcome.qml cf49d2f
>
> Diff: http://git.reviewboard.kde.org/r/109592/diff/
>
>
> Testing
> -------
>
> build + installed with kdesrc-build. tested with plasmoidviewer.
>
> i could not test if it still plays the video because that didn't work for me with master before.
> should be fine though
>
>
> Thanks,
>
> Michael Bohlender
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130322/1d4a8dd7/attachment.html>
More information about the Plasma-devel
mailing list