Review Request 109604: Model to provide easy access to KWin's Clients from QML
Thomas Lübking
thomas.luebking at gmail.com
Thu Mar 21 21:06:17 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109604/#review29660
-----------------------------------------------------------
kwin/scripting/scripting_model.h
<http://git.reviewboard.kde.org/r/109604/#comment22099>
Exclusion/s?
"Exclude/s" sounds "nounalized" and -to me- more like a defined list (Ie. window A, B and D) than a list of cases.
kwin/scripting/scripting_model.h
<http://git.reviewboard.kde.org/r/109604/#comment22100>
... and you don't say "Restricted/s" here either ;-)
kwin/scripting/scripting_model.h
<http://git.reviewboard.kde.org/r/109604/#comment22101>
... setExclusions() .. etc.
kwin/scripting/scripting_model.h
<http://git.reviewboard.kde.org/r/109604/#comment22095>
"BranchFoliage" ;-)
Fwwi, imo there's too much usage of generic "clientGroup" in kwin.
The oldest definition refers to clients with a common leader, then the tabgroup was called that ...
kwin/scripting/scripting_model.h
<http://git.reviewboard.kde.org/r/109604/#comment22096>
Is it a ForkLevel?
kwin/scripting/scripting_model.cpp
<http://git.reviewboard.kde.org/r/109604/#comment22097>
if ((excludes & ClientModel::ExcludeDesktopWindows) && client->isDesktop()) {
return true;
}
just as note, the current double branching makes it look more complex as it actually is.
(But it's your code and i'm not in the position to teach anybody style rules ;-)
kwin/scripting/scripting_model.cpp
<http://git.reviewboard.kde.org/r/109604/#comment22098>
considered to keep m_clients and m_ids as hash/map or at least a pair (implicitly documenting "this is assigned and has to be in sync")
Most on terminology, but think about grouping m_ids and m_clients
The last "ClientGroup" lost the connection quite some times ... =)
- Thomas Lübking
On March 20, 2013, 12:07 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109604/
> -----------------------------------------------------------
>
> (Updated March 20, 2013, 12:07 p.m.)
>
>
> Review request for kwin and Plasma.
>
>
> Description
> -------
>
> Model to provide easy access to KWin's Clients from QML
>
> A new ClientModel is added which provides multiple different views on
> KWin's Clients. The model is organized as a tree model supporting the
> following levels:
> * activities
> * virtual desktops
> * screens
> * none
>
> The levels can be ordered in whatever way one wants. That is the tree
> structure can have an ordering of activities then virtual desktops or
> the other way around.
>
> In addition the model provides Exclude flags to exclude clients of
> certain types. E.g. it's possible to exclude all windows which are not on
> the current desktop or all windows which are of type dock.
>
> The model gets automatically updated whenever a Client is added/removed
> or changes a state in a way that it should be excluded/included. This is
> currently still rather limited, as some signals from KWin core are not
> yet available. Also the model does not yet react on screen, desktop and
> activity changes.
>
> The ClientModel is not directly exported to QML. Instead there are
> specific sub classes for certain common orderings. This solutions is
> chosen to workaround some limitations of QML. The initial idea was to
> use a property taking a list of the levels, but this doesn't work because
> we are not notified when the QDeclarativeListProperty changes.
>
> Currently the following models are provided to QML:
> * ClientModel -> no restrictions
> * ClientModelByScreen -> ordering by screen
> * ClientModelByScreenAndDesktop -> screen, then desktop
>
> These can be used to get all Clients:
> ClientModel {
> }
>
> Or to get the classic Present Windows on current desktop:
> ClientModelByScreen {
> excludes: ClientModel.ExcludeOtherDesktops | ClientModel.ExcludeNotAcceptingFocus | ...
> }
>
> Or to get the classic Present Windows on all desktops:
> ClientModelByScreen {
> excludes: ClientModel.ExcludeNotAcceptingFocus | ...
> }
>
> Or our well known desktop grid:
> ClientModelByScreenAndDesktop {
> id: desktopGrid
> excludes: ClientModel.ExcludeNotAcceptingFocus | ...
> }
>
> To support filtering as known by the Present Windows effect one can use
> a ClientFilterModel, which is a QSortFilterProxyModel filtering on
> window caption, role and class:
> ClientFilterModel {
> id: filterModel
> clientModel: desktopGrid
> filter: filterItem.text
> }
>
> In case it's a tree level obviously QML does not support this correctly.
> So we need to use a VisualDataModel:
> VisualDataModel {
> id: clientModel
> model: filterModel
> Component.onCompleted: {
> clientModel.rootIndex = modelIndex(0);
> clientModel.rootIndex = modelIndex(0);
> clientModel.delegate = thumbnailDelegate;
> }
> }
>
> As we can see, the rootIndex has to be set to the level which contains
> the Clients. Also it seems to be important to create the delegate after
> the model index has been set. The idea is to have only one ClientModel
> and multiple VisualDataModels if multiple views on the data is needed.
>
> The model has been tested with a painful modeltest session. It looks good
> so far modulo the listed limitations and that modeltest is not liking
> closing Yakuake in the ClientModelByScreenAndDesktop setup, though it
> works fine in real world testing.
>
> ===
> Support saturation/brightness in ThumbnailItem
>
> Two new properties saturation and brightness are added to the
> ThumbnailItem which can be set from QML.
>
> The properties are honoured by the Scene when rendering the thumbnail.
> ===
>
> Plasma devs are added to get access to their QML knowledge :-)
>
>
> Diffs
> -----
>
> kwin/CMakeLists.txt ecddc55ed89cb4fcb143561e57534b1bb4ea3832
> kwin/scene.cpp 939f000f0c3d09ffacccb0b25c50f83f0010ef47
> kwin/scripting/scripting.cpp e124827174317ab6adbfdb90cec796a02e7bd2b7
> kwin/scripting/scripting_model.h PRE-CREATION
> kwin/scripting/scripting_model.cpp PRE-CREATION
> kwin/thumbnailitem.h f7dc4fe621e9cf2786794d1be55930ce79ca5c7c
> kwin/thumbnailitem.cpp 66b665a685188767201ada7d5cfbb32a0ea7ff0a
>
> Diff: http://git.reviewboard.kde.org/r/109604/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Example PresentWindows/DesktopGrid QML
> http://git.reviewboard.kde.org/media/uploaded/files/2013/03/20/main.qml
> WindowItemComponent.qml - needed for the example
> http://git.reviewboard.kde.org/media/uploaded/files/2013/03/20/WindowItemComponent.qml
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130321/9908527d/attachment.html>
More information about the Plasma-devel
mailing list