Review Request 109648: Implement the implicitWidth/implicitHeight of the chat plasmoid
Marco Martin
notmart at gmail.com
Thu Mar 21 19:11:34 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109648/#review29653
-----------------------------------------------------------
Ship it!
Ship It!
- Marco Martin
On March 21, 2013, 5:37 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109648/
> -----------------------------------------------------------
>
> (Updated March 21, 2013, 5:37 p.m.)
>
>
> Review request for Plasma, Telepathy and David Edmundson.
>
>
> Description
> -------
>
> Implements those 2 properties, aliasing to the similar preferredWidth/Height.
>
> When I have Icon-Only tasks + Chat plasmoid in a panel, their growth rendered unpredictable. Implementing the implicit seems to solve this problem.
>
>
> Diffs
> -----
>
> chat/org.kde.ktp-chat/contents/ui/main.qml e11269e
>
> Diff: http://git.reviewboard.kde.org/r/109648/diff/
>
>
> Testing
> -------
>
> I was reproducing the problem regularly since a couple of days, then now I cannot reproduce anymore.
>
> There's no testing per se, though...
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130321/f4f48833/attachment-0001.html>
More information about the Plasma-devel
mailing list