Review Request 109648: Implement the implicitWidth/implicitHeight of the chat plasmoid
David Edmundson
david at davidedmundson.co.uk
Thu Mar 21 18:54:33 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109648/#review29651
-----------------------------------------------------------
Ship it!
I'm very much against shipping any patches if we don't know why it fixes it. From what I can see from declarative/declarativeitemcontainer.cpp it just sets the minimumWidth to it... which I would have thought it would be doing anyway when we set the minimumWidth.
Any documentation on implicitWidth, preferredWidth, minimumWidth and width would be incredibly useful.
Given the proximity to the deadline and your testing I can't see this breaking anything, so ship it if you're confident with it.
- David Edmundson
On March 21, 2013, 5:37 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109648/
> -----------------------------------------------------------
>
> (Updated March 21, 2013, 5:37 p.m.)
>
>
> Review request for Plasma, Telepathy and David Edmundson.
>
>
> Description
> -------
>
> Implements those 2 properties, aliasing to the similar preferredWidth/Height.
>
> When I have Icon-Only tasks + Chat plasmoid in a panel, their growth rendered unpredictable. Implementing the implicit seems to solve this problem.
>
>
> Diffs
> -----
>
> chat/org.kde.ktp-chat/contents/ui/main.qml e11269e
>
> Diff: http://git.reviewboard.kde.org/r/109648/diff/
>
>
> Testing
> -------
>
> I was reproducing the problem regularly since a couple of days, then now I cannot reproduce anymore.
>
> There's no testing per se, though...
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130321/5a0992dd/attachment.html>
More information about the Plasma-devel
mailing list