Review Request 109507: fix bug 316290

Sebastian Kügler sebas at kde.org
Wed Mar 20 17:13:57 UTC 2013



> On March 20, 2013, 2:06 p.m., Aaron J. Seigo wrote:
> > plasmate/startpage.cpp, line 151
> > <http://git.reviewboard.kde.org/r/109507/diff/1/?file=119962#file119962line151>
> >
> >     how about server-database?
> 
> Giorgos Tsiapaliokas wrote:
>     yes it nice.
>     
>     should I push the commit?

Yes, please.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109507/#review29554
-----------------------------------------------------------


On March 20, 2013, 2:04 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109507/
> -----------------------------------------------------------
> 
> (Updated March 20, 2013, 2:04 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> this patch fixes the bug 316290.
> 
> I couldn't a dataengine icon so I used the plasma icon.
> Is it ok, do you have anything else to purpose?
> 
> 
> This addresses bug 316290.
>     http://bugs.kde.org/show_bug.cgi?id=316290
> 
> 
> Diffs
> -----
> 
>   plasmate/startpage.cpp f16a5df 
> 
> Diff: http://git.reviewboard.kde.org/r/109507/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130320/bb446ea6/attachment.html>


More information about the Plasma-devel mailing list