Review Request 109528: port bodega-server to the new node-postgres API
Aaron J. Seigo
aseigo at kde.org
Wed Mar 20 14:04:34 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109528/#review29553
-----------------------------------------------------------
Ship it!
small matter of a missing ';' but is good to go.. i had also seen these errors but it was languishing on my TODO to get into it. thanks for beating me to it! :)
server/lib/bodegadb.js
<http://git.reviewboard.kde.org/r/109528/#comment22037>
missing a ;
- Aaron J. Seigo
On March 16, 2013, 8:29 p.m., Giorgos Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109528/
> -----------------------------------------------------------
>
> (Updated March 16, 2013, 8:29 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> This patch ports the bodega-server into the new node-postgres API,
> this output which comes from the node-postgres module contains more
> info about the new API
>
>
> WARNING!!
> pg.connect(function(err, client) { ...}) is deprecated and will be removed it v1.0.0 (very soon)
> instead, use pg.connect(function(err, client, done) { ... })
> automatic releasing of clients back to the pool was a mistake and will be removed
> please see the following for more details:
> https://github.com/brianc/node-postgres/wiki/pg
> https://github.com/brianc/node-postgres/issues/227
> https://github.com/brianc/node-postgres/pull/274
> feel free to get in touch via github if you have questions
>
>
> Diffs
> -----
>
> server/lib/bodegadb.js d17a77e
>
> Diff: http://git.reviewboard.kde.org/r/109528/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Giorgos Tsiapaliokas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130320/2e079438/attachment.html>
More information about the Plasma-devel
mailing list