Review Request 109606: Use nocover svg from plasma theme

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109606/#review29550
-----------------------------------------------------------



applets/nowplaying/CMakeLists.txt
<http://git.reviewboard.kde.org/r/109606/#comment22035>

    this should stay inside the package and be placed under images/widgets/nocover.svgz


- Aaron J. Seigo


On March 20, 2013, 1:03 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109606/
> -----------------------------------------------------------
> 
> (Updated March 20, 2013, 1:03 p.m.)
> 
> 
> Review request for Plasma and Alex Merry.
> 
> 
> Description
> -------
> 
> This patch makes possible for plasma themes to have a custom nocover, until now, the QML re-written version always had it hardcoded within the plasmoid.
> With the patch, the nocover goes to ~desktoptheme/default/widgets, and that way it is always default, unless a plasma theme provides another svg.
> 
> 
> Diffs
> -----
> 
>   applets/nowplaying/CMakeLists.txt 4a1ff12 
>   applets/nowplaying/nocover.svgz PRE-CREATION 
>   applets/nowplaying/package/contents/images/nocover.svgz 67e8c28c2aecc23621ea057cdc57ac4d04a660ea 
>   applets/nowplaying/package/contents/ui/AlbumArt.qml 7c70b0f 
> 
> Diff: http://git.reviewboard.kde.org/r/109606/diff/
> 
> 
> Testing
> -------
> 
> Using any theme that doesn't have the svg, makes the plasmoid uses the default one. Changed theme that *does* have another nocover, it changes correctly to that one.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130320/bf92bcc1/attachment.html>