Review Request 106110: Make autohide panel do not intercept events in fullscreen app

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106110/#review29461
-----------------------------------------------------------



plasma/desktop/shell/panelview.cpp
<http://git.reviewboard.kde.org/r/106110/#comment21983>

    we do not use Kephal anymore (I'm surprised you didn't run into compile errors). We use QDesktopWidget nowadays.
    
    primaryScreen also looks wrong as that's the "primary" and not the current screen. You really need to compare the geometries of the panel window with the geometry of the activeWindow.


- Martin Gräßlin


On March 18, 2013, 4:15 p.m., Alexey Shmalko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106110/
> -----------------------------------------------------------
> 
> (Updated March 18, 2013, 4:15 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> -------
> 
> Make autohide panel do not intercept events in fullscreen app.
> 
> I changed PanelView::createUnhideTrigger() to check whether current active application is in fullscreen mode. So in fullscreen applications panel will be always hidden.
> 
> 
> This addresses bug 217560.
>     http://bugs.kde.org/show_bug.cgi?id=217560
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/panelview.cpp 7713740 
> 
> Diff: http://git.reviewboard.kde.org/r/106110/diff/
> 
> 
> Testing
> -------
> 
> Tested with patched gentoo ebuild. Works fine.
> 
> 
> Thanks,
> 
> Alexey Shmalko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130318/32e84b12/attachment.html>