Review Request 105139: Plasmate: Add tabbox previewer

[Kevin Kofler]

> On March 14, 2013, 9:14 p.m., Kevin Kofler wrote:
> > Unfortunately, the binary files (the .png images) are not contained in the diff, and were therefore created in the repository as 0-byte files!
> 
> Antonis Tsiapaliokas wrote:
>     @kevin:
>     
>     Yes, that's correct, but i am using local branches for my patches. So i don't think that there is an issue with the plasmate.
>     Did you find any bug about those images? Is there some issue?

https://projects.kde.org/projects/extragear/sdk/plasmate/repository/revisions/master/show/plasmate/previewer/windowswitcher/thumbnails

Everything is 0 bytes there (and thus also in the Plasmate 1.0 tarballs).


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105139/#review29232
-----------------------------------------------------------


On June 11, 2012, 4:15 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105139/
> -----------------------------------------------------------
> 
> (Updated June 11, 2012, 4:15 p.m.)
> 
> 
> Review request for kwin, Plasma and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> Hello,
> 
> This is the second task of my GSoC.Everything seems to work execpt from:
> 
> 1)The icon of the refresh (in the tabbox previewer) is not visible.
> 2)I couldn't try if the refresh works...
> 
> 
> This addresses bug master.
>     http://bugs.kde.org/show_bug.cgi?id=master
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 12f8a3a 
>   editors/metadata/metadataeditor.cpp afc6250 
>   mainwindow.cpp 6f72624 
>   previewer/windowswitcher/standalone/main.cpp PRE-CREATION 
>   previewer/windowswitcher/standalone/windowswitcherpreviewer.h PRE-CREATION 
>   previewer/windowswitcher/standalone/windowswitcherpreviewer.cpp PRE-CREATION 
>   previewer/windowswitcher/tabboxdelegate.qml PRE-CREATION 
>   previewer/windowswitcher/tabboxpreviewer.h PRE-CREATION 
>   previewer/windowswitcher/tabboxpreviewer.cpp PRE-CREATION 
>   previewer/windowswitcher/thumbnailitem.h PRE-CREATION 
>   previewer/windowswitcher/thumbnailitem.cpp PRE-CREATION 
>   previewer/windowswitcher/thumbnails/dolphin.png PRE-CREATION 
>   previewer/windowswitcher/thumbnails/kmail.png PRE-CREATION 
>   previewer/windowswitcher/thumbnails/konqueror.png PRE-CREATION 
>   previewer/windowswitcher/thumbnails/systemsettings.png PRE-CREATION 
>   previewer/windowswitcher/windowswitcher.h PRE-CREATION 
>   previewer/windowswitcher/windowswitcher.cpp PRE-CREATION 
>   startpage.cpp cb14f16 
> 
> Diff: http://git.reviewboard.kde.org/r/105139/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/105139/s/590/
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130314/8762b962/attachment.html>