Review Request 106110: Make autohide panel do not intercept events in fullscreen app

[Martin Gräßlin]

> On March 13, 2013, 8:49 a.m., Martin Gräßlin wrote:
> > plasma/desktop/shell/panelview.cpp, lines 1494-1495
> > <http://git.reviewboard.kde.org/r/106110/diff/3/?file=119560#file119560line1494>
> >
> >     the logic looks wrong. If there is no activeWindow you still want to trigger the unhide.
> 
> Alexey Shmalko wrote:
>     Oh. I see.
>     
>     So it's better to write it something like
>     
>     bool fancy = shouldHintHide() && (!activeWindow.valid() || activeWindow.isOnCurrentScreen() && activeWindow.hasState(NET::FulScreen));
>     
>     or even better
>     
>     bool fancy = shouldHintHide();
>     if (activeWindow.valid()) {
>       fancy = fancy && activeWindow.isOnCurrentDesktop() && activeWindow.hasState(NET::FullScreen);
>     }

I would go for:
bool fancy = shouldHintHide();
if (fancy && activeWindow.valid()) {
  fancy = activeWindow.isOnCurrentDesktop() && activeWindow.hasState(NET::FullScreen);
  // TODO: add further checks, like fullscreen window on same screen as panel
}


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106110/#review29108
-----------------------------------------------------------


On March 12, 2013, 11:45 p.m., Alexey Shmalko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106110/
> -----------------------------------------------------------
> 
> (Updated March 12, 2013, 11:45 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> -------
> 
> Make autohide panel do not intercept events in fullscreen app.
> 
> I changed PanelView::createUnhideTrigger() to check whether current active application is in fullscreen mode. So in fullscreen applications panel will be always hidden.
> 
> 
> This addresses bug 217560.
>     http://bugs.kde.org/show_bug.cgi?id=217560
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/panelview.cpp 7713740 
> 
> Diff: http://git.reviewboard.kde.org/r/106110/diff/
> 
> 
> Testing
> -------
> 
> Tested with patched gentoo ebuild. Works fine.
> 
> 
> Thanks,
> 
> Alexey Shmalko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130313/27d19065/attachment.html>