Review Request 109433: Zero size pager in default panel layout when in panel

Mark Gaiser markg85 at gmail.com
Mon Mar 11 19:33:54 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109433/#review29020
-----------------------------------------------------------


I'm biased.. i obviously want this change to get in.

- Mark Gaiser


On March 11, 2013, 6:33 p.m., Aaron J. Seigo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109433/
> -----------------------------------------------------------
> 
> (Updated March 11, 2013, 6:33 p.m.)
> 
> 
> Review request for Plasma and Mark Gaiser.
> 
> 
> Description
> -------
> 
> Fixes zero size pager in default panel, makes it optional via a non-GUI config option which is set in the default panel layout script.
> 
> One thing that still needs work with this is that existing installations will suddenly have pagers that show up with 1 virtual desktop. An update script needs to be written for this before it can be pushed.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/pager/pager.h 764cb01 
>   plasma/desktop/applets/pager/pager.cpp 228af8e 
>   plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js afd1f2c 
> 
> Diff: http://git.reviewboard.kde.org/r/109433/diff/
> 
> 
> Testing
> -------
> 
> None yet; just wanted to sketch out the proposed solution.
> 
> 
> Thanks,
> 
> Aaron J. Seigo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130311/f1ab68c8/attachment-0001.html>


More information about the Plasma-devel mailing list